Jmeyer1292 / opw_kinematics

Closed form IK for parallel base, spherical wrist industrial manipulators
Apache License 2.0
69 stars 26 forks source link

ros_industrial_cmake_boilerplate as system dependency? #73

Open rjoomen opened 1 year ago

rjoomen commented 1 year ago

Question: Why is ros_industrial_cmake_boilerplate a source dependency in dependencies.rosinstall, and why is 0.3.0 used? I compiled it with ros_industrial_cmake_boilerplate as a system dependency (using ros-humble-ros-industrial-cmake-boilerplate 0.4.0) and that seems to work fine.

Levi-Armstrong commented 1 year ago

Although it is released for ros this is used outside the ros context which may not have a released version. This is the primary reason for it being in the rosinstall, but if you know of a better way to handle this please let us know.

In the case of it using an older version is no one has taking the time to update it for this package.

rjoomen commented 1 year ago

I understand, thanks for the explanation. Maybe having a dependencies-ros.rosinstall and a dependencies.rosinstall side by side could be an option?

Levi-Armstrong commented 1 year ago

That works for me.