search

JnCrMx / discord-game-sdk4j

Java bindings for Discord's Game SDK
MIT License
122 stars 23 forks source link

Ask to Join / Join Buttons not showing #13

Closed hypherionmc closed 3 years ago

hypherionmc commented 3 years ago

So, firstly, really cool library! I love using this!

I ran into an issue while using it. I built your Networking branch and it's working, except the Join / Ask to Join buttons refuse to show up.

I used your example code for the activity, but it doesn't show at all.

Some more info if it helps:

Windows 10 Pro Java 1.8.0_265

Compiled the DLL library using Visual Studio 2019

Edit: It works with your last jitpack release

JnCrMx commented 3 years ago

Hmmm... I am sadly unable to reproduce this.

Could you please check that you compiled the native library against version 2.5.6 (or whatever version you are using to run the example with) of the Discord Game SDK?

Mixing different version of the SDK has also been the cause for many issues I faced, so I would suspect that this might be the cause of the trouble.

hypherionmc commented 3 years ago

Hi thanks for the reply.

I did compile with 2.5.6 and I'm running 2.5.6.

The only difference between the two tests was the JNI libraries. If possible, do you have some compiled ones for that branch that I can test with? I narrowed it down to being an issue with my version of the compiled libraries, as swapping from the networking branch to 0.3.1 with the same code, works. Swapping back to Networking causes it to fail.

JnCrMx commented 3 years ago

Here's a build that I just made on a Windows 10 Version 2004 virtual machine: winbuild.zip

Java-Version: AdoptJDK jdk-8.0.265.01-hotspot (hopefully) Compiler: MSVC 19.28.29335.0

hypherionmc commented 3 years ago

I will try it out when I get home tonight and give you feedback. Thank you very much

hypherionmc commented 3 years ago

I will also keep an eye out for the Voice features. Can't wait for it to be implemented :D

hypherionmc commented 3 years ago

Hey. Sorry for only responding now. Your library as well as 0.4 works, so the issue was with my own compiled library

JnCrMx commented 3 years ago

As this issue is pretty old I assume I can just close it. I'd like to tidy up the issues a little.

If there is any build problems with the newer version that you feel like need to be discussed, please just re-open this issue or make a new one ;9

hypherionmc commented 3 years ago

Oh yeah sorry, I forgot to close this. Can confirm this issue has been fixed