search

JnCrMx / discord-game-sdk4j

Java bindings for Discord's Game SDK
MIT License
121 stars 23 forks source link

Clean up pure-java build process #58

Closed letorbi closed 1 year ago

letorbi commented 1 year ago

This PR removes the Maven instructions to compile and copy the native binding libraries, since they are not required anymore.

Apart from that is also removes an unfulfilled include statement, which caused the build process to fail.

With these fixes the java-impl brach can be compiled with: mvn install -DskipTests -Dmaven.javadoc.skip=true

I consider the missing JavaDoc comments, which cause the JavaDoc plugin to fail, a bug that will be fixed in a future commit, so I did not remove the JavaDoc part from the Maven config.

JnCrMx commented 1 year ago

Oh, thank you so much for this PR. I thought I had already done that, but it seems like I did not. :sweat_smile: