search

JnCrMx / discord-game-sdk4j

Java bindings for Discord's Game SDK
MIT License
114 stars 23 forks source link

Maven Version Numbers #68

Closed LakMoore closed 9 months ago

LakMoore commented 1 year ago

Would you consider making a new release but altering the version number on the Maven Repo from "v0.5.6" to "0.5.6"?

The addition of the "v" makes the version number not compliant with Maven Version numbers and my dependency manager refuses to work because of that.

https://cwiki.apache.org/confluence/display/MAVENOLD/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-DependencyVersionRanges

image

JnCrMx commented 1 year ago

Hi,

In the pom.xml the version number is written without the "v".

The prefix is only used for the Git tags.

Furthermore, Jitpak supports leaving out the "v" and still delivers the correct artifacts.

So it should be no problem to simply use those, right?

LakMoore commented 1 year ago

I thought I tried it without the “v”.

I’ll give it another try.

Thanks for the reply.

On Thu, 3 Aug 2023 at 20:26, JCM @.***> wrote:

Hi,

In the pom.xml the version number is written without the "v".

The prefix is only used for the Git tags.

Furthermore, Jitpak supports leaving out the "v" and still delivers the correct artifacts.

So it should be no problem to simply use those, right?

— Reply to this email directly, view it on GitHub https://github.com/JnCrMx/discord-game-sdk4j/issues/68#issuecomment-1664512486, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSRIIQPH4CA7GLW5NJNJL3XTP3NHANCNFSM6AAAAAA3DFYQ3A . You are receiving this because you authored the thread.Message ID: @.***>