search

Jnegrier / wdio-novus-visual-regression-service

Fork of wdio-visual-regression-service by Zinserjan, with compability with WebdriverIO V6
MIT License
7 stars 4 forks source link

Add `isNewScreenshot` to Comparison Results #8

Open emilyrohrbough opened 4 years ago

emilyrohrbough commented 4 years ago

Re-logging this issue from https://github.com/zinserjan/wdio-visual-regression-service/issues/83

Often times new screenshots are not generated locally and checked in. This is not caught because our Travis CI builds create new reference screenshots are generated with no indication in the comparison results. It would be helpful to check if for a isNewScreenshot result boolean to assert all screenshots have been properly generated.

The BaseCompare would need changed here

The LocaleCompare would need changes in these places:

  1. When new
  2. When exists here and here
emilyrohrbough commented 4 years ago

For reference a PR has been submitted to wdio-visual-regression-service by @webOS101 for this feature: https://github.com/zinserjan/wdio-visual-regression-service/pull/103