Jnjy / pe

0 stars 0 forks source link

Date Applied used as Date of Acceptance after edit #3

Open Jnjy opened 1 year ago

Jnjy commented 1 year ago

Steps to reproduce:

  1. add n/NUS r/Software Engineer s/Applied d/2021-02-01 c/2103 pe wooo

image.png

  1. edit 9 s/accepted

image.png

Expected: My thought was that InternBuddy will prompt the user for the date of acceptance instead of using the current date and carry forward when status of application is updated.

As mentioned, I think the team can include compulsory date parameter when the user attempts to change the status of application to ensure that the date is always updated with the status.

Severity is given as low because it does not affect normal application operation.

Cheers!

soc-pe-bot commented 1 year ago

Team's Response

Hi there! Thanks for your suggestion.

Let us explain why we did not make adding of a date compulsory when we change the status of an application. Consider the case where you entered an entry but only typed the status wrongly. Hence, the natural thing to do is to just edit the status instead of editing both the status and the date. Thus, adding of a date is not compulsory when we change the status.

However, we understand your concern. A user might change the status but forget to update the date, hence the date would be outdated. We can indeed do better, such as displaying a warning message that reminds the user that the status has been changed but the date has not. Thus, we find your argument valid and would classify this issue as such:

  1. This additional feature is a good to have but not must have. It can help remind users to avoid mistakes. Instead, ensuring that the edit command works correctly is important than this enhancement. Thus, it is something we would consider in the future, and we label it as response.NotInScope.
  2. The lack of this feature does not affect the critical functioning of InternBuddy where it is a bonus feature. Hence, it label this as a severity.Low.

We appreciate your suggestion!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]