search

Jnjy / pe

0 stars 0 forks source link

Allow Insertion of application with deadline earlier than the current date #4

Open Jnjy opened 1 year ago

Jnjy commented 1 year ago

Steps to reproduce:

  1. add n/NUS r/Software Engineer s/Applied d/2010-02-01 c/outdated application

Expected: My thought is that it will reject insertion of new application with deadline that has already passed, as applying for past job ad will result in nothing. Hence, it will be just another item in the memory.

Actual:

Date of insertion of the new job posting: 14-04-2023

image.png

Suggestion: It would be better if there is a check on the date of insertion of NEW application to ensure that the new job applied always has a deadline which is in the future.

Severity is given as low because it does not affect normal application operation.

nus-pe-script commented 1 year ago

Team's Response

Hello there! Thanks for writing in.

We understand that when one searches for internships online, he might encounter internships with deadlines already over. However, there is a possibility that he wants to keep track of such internship opportunities so he knows what are some companies he had missed and would take note of in the future when they release new internship opportunities. Therefore, what you have observed is a feature and not a bug. We allow the user to add an entry with status New with a date that has passed because the user might just be interested in keeping track of an internship opportunity that has passed but he did not apply for. This design allows for greater flexibility since the user can use InternBuddy to track internships that he's interested in but had missed the deadlines.

Therefore, our team does not consider this as a bug. It is a design consideration. Nevertheless, thanks for taking the time to consider this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hey InternBuddy!

Thanks for your response. However, I beg to differ with your reasoning for allowing such behavior. Before my reasoning, I have attached a snapshot of the definition of NEW included in your UG to aid my explanation.

image.png

As shown in the screenshot I have provided, the definition of NEW indicates that it is meant to categorize an internship that you have yet to apply for. Therefore, I believe that the tag should only be used for internship opportunities that you are currently considering and intend to apply for in the future. Using the "NEW" tag for a internship posting that has already past does not seem logical or consistent with its intended use.

he wants to keep track of such internship opportunities so he knows what are some companies he had missed and would take note of in the future when they release new internship opportunities

I agree with this statement, there are always opportunities that student interns do not want to miss, and if missed, would like to keep track of those opportunities. However, allowing students to add past internships with a NEW tag does not facilitate their ability to keep track of missed opportunities. For instance, if I am to use the command find s/NEW, I would only want to view the latest internship positions that I have yet to apply and wish to proceed with the applications. But what if I wish to search for internship opportunities that I have missed, does the same command, find s/NEW, serves the purpose? I would not say so.

A way to better address this issue will be employing additional STATUS specifically for tracking missed internships in addition to the current status pre-defined by InternBuddy. This could be denoted by a status such as MISSED or OVERDUE, which would clearly categorize missed opportunities and aid in tracking progress.

our team does not consider this as a bug

I do also think that this is not a bug, but rather a design oversight. While this may not have an immediate affect the application's usability, it may pose a problem to users who rely on up-to-date information on latest available opportunities. That is why I have categorized this under FeatureFlaw with severity.low. As I have outlined earlier, this needs to be address to ensure the application meets its purpose of keeping track of internships, be it passed, present or future.

With that, I disagree with your rejection of this issue. In addition, the more reasonable approach for this issue would be NotInScope as it is an issue that the team needs to take care of in the future iteration (if there is any).