Closed dfangl closed 2 years ago
Hi and thanks for the bug report and the pull request with the new product_id value!
The other thing you noticed is the result of my decision to use threads to update the Busylight family of devices in the background. Unfortunately, HIDAPI doesn't support accessing HID devices from multiple threads and has recently started crashing under MacOS in the tests (and presumably Linux too, I haven't looked to closely at the results of the automated testing).
I'm in the process of re-writing with an eye towards using asyncio to keep everything in a single thread while taking advantage of an asyncio event loop to deliver keep-alive messages to Busylights. Easily my least favorite light since it needs so much hand-holding.
No ETA for the re-write as I've just begun this weekend, however it's giving me the opportunity to clean up a bunch of kludges.
Thanks for the quick response! If you need any help, or help testing, I would be happy to lend a hand!
Software Versions:
General Type of Problem
Describe the Problem Busylight Omega is not detected. It seems a new revision is out, with the product ID
0x3BCF
. Currently, only 0x3BCD is defined. Also, busylight throws an error for a failing assertion on exit.Expected Behavior Correct detection of omega light and no assertion error on exit.
Error Output Error missing Product ID:
Error assertion (after adding product ID):
Additional Infos
I will file a quick PR for the missing ID myself, not sure what goes on with the wrong assertion though, and cannot test with other devices if this is something new with the new Product ID. Is this error currently expected?