search

JnyJny / busylight

Control USB connected presence lights from multiple vendors via the command-line or web API.
Apache License 2.0
214 stars 25 forks source link

Class and file conventions #193

Closed henryruhs closed 1 year ago

henryruhs commented 1 year ago
  1. the status indicator does not follow the class convention.

busylight.lights.plantronics import status_indicator should be Status_Indicator

  1. the fit statusb does not follow the file convention

fit_statUSB.py should be fit_statusb.py

JnyJny commented 1 year ago

Pull request?

JnyJny commented 1 year ago

Also I can't find any instances of busylight.lights.plantronics import status_indicator in the code base.

henryruhs commented 1 year ago

I was wrong (properly need so sleep), there is indeed Status_Indicator.