search

JnyJny / busylight

Control USB connected presence lights from multiple vendors via the command-line or web API.
Apache License 2.0
220 stars 25 forks source link

[BUG] Older Blynclight not recognized by busylight #73

Closed JnyJny closed 2 years ago

JnyJny commented 2 years ago

@hewasajumperboy wrote:

Hey,

I'm trying to use my (probably older) light with this project. It works in the previous, depreciated blynclight repo and looking at embrava/blynclight.py the vendor id for my light doesn't show up in the list. Output from my pi below:

pi@nightlight:~ $ busylight on
Light '0' not in the range of 0..-1
pi@nightlight:~ $ dmesg | tail
[ 7218.521658] Voltage normalised (0x00000000)
[ 9518.695285] usb 1-1.2: USB disconnect, device number 4
[17252.456676] usb 1-1.3: USB disconnect, device number 6
[17254.285218] usb 1-1.3: new low-speed USB device number 7 using dwc_otg
[17254.429614] usb 1-1.3: New USB device found, idVendor=0e53, idProduct=2516, bcdDevice= 1.00
[17254.429637] usb 1-1.3: New USB device strings: Mfr=0, Product=1, SerialNumber=0
[17254.429652] usb 1-1.3: Product: Blynclight
[17254.436605] hid-generic 0003:0E53:2516.000A: hiddev96,hidraw0: USB HID v1.10 Device [Blynclight] on usb-3f980000.usb-1.3/input0
JnyJny commented 2 years ago

Yup, there's a typo in busylight/lights/embrava/blynclight.py. Look for a patch update shortly.

JnyJny commented 2 years ago

Pushed a468d6a84f19261fc4d656d0082d852fc3ab090b which should fix the problem. Could you verify by installing the latest busylight from pypi ( 0.12.10 )?

JnyJny commented 2 years ago

And to be perfectly candid, I don't think it was a typo so much as I used a byte-swapped version of the vendor identifier. Either way it's a bug and should be fixed now. :)

JnyJny commented 2 years ago

This a dup before I knew you could transfer issues.