Jo3LW / pe

0 stars 0 forks source link

Inaccurate error throw for add command #7

Open Jo3LW opened 1 year ago

Jo3LW commented 1 year ago

Step: 1) Type add n/John Doe/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 c/3.50/4.00 g/male u/Nanyang Polytechnic gd/05-2024 m/Computer Science ji/173296 jt/Software Engineer Intern t/rejected t/KIV into command box

Expectation: Throw error saying the p/ field in missing Actual: Throw a generic error that does not show what I forgot to enter

The command is quite long, thus people might forget to input certain fields. Thus it would be better to throw a more accurate error so users know what went wrong.

Screenshot 2022-11-11 at 4.52.14 PM.png

soc-pe-bot commented 1 year ago

Team's Response

Inside the error shown, it's already specified that an add command should have all fields. Hence, it's implicitly saying that there is a missing field if the command is rejected.

This is something that the user needs to take into account when inputting add command. Otherwise, if the user doesn't want to input an applicant one by one, they can use import command as it also can achieve the same goal.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As seen in the feature flaws, an error message that is not specific enough is considered a feature flaw. Implicitly saying that a missing field is present but not stating which field is too general of an error and does not prompt the user to know where to find the missing field.

Screenshot 2022-11-17 at 8.18.24 PM.png