search

JoC0de / UnityVisualStudioSolutionGenerator

Visual Studio Solution Generator for Unity to improve developer productivity when working with multi-package unity projects
MIT License
6 stars 1 forks source link

asmrefs should be merged with the referenced asmdef #8

Open laicasaane opened 1 year ago

laicasaane commented 1 year ago

Tested on https://github.com/Dreaming381/lsss-wip

Expected behaviour: Files in the folder contains Lsss.Systems.Ref.asmref should be merged with the folder contains Lsss.Systems.asmdef to become a single Lsss.Systems.csproj.

Actual behaviour: Lsss.Systems.Ref.asmref turned into a separated Lsss.Systems.Ref.csproj.

JoC0de commented 1 year ago

What are .asmref files exactly doing? I never used them. The solution generator currently only edits the .csproj files generated by Unity it doesn't remove them. Update: Ok I think I understand a little bit about how .asmref work. But how should the projects be combined? When Lsss.Systems.Ref.asmref and Lsss.Systems.asmdef are placed in different folders. Than I would need to use the <Link> witch leads to not being able to rename the file in Visual Studio. Or the .csproj need to live in a parent folder, but than you get more depth inside the Solution Explorer hierarchy.

laicasaane commented 1 year ago

Or the .csproj need to live in a parent folder, but than you get more depth inside the Solution Explorer hierarchy.

I think this wouldn't be a problem compared to the usefulness of .asmref in some situations. There is also a situation where I need to expose internal code of a package inside the Library/PackageCache folder. In this case, I wouldn't mind a deep folder hierarchy because the .csproj has to be at the root level of the project.

laicasaane commented 5 months ago

Hi, recently I have to modify some packages that contain asmrefs, each time I have to disable this tool. If this issue will be resolved it would be great. Thanks!