search

JoDehli / PyLoxone

Python Loxone binding
Apache License 2.0
162 stars 40 forks source link

Code cleanup? #259

Open gigatexel opened 1 month ago

gigatexel commented 1 month ago

Hi @JoDehli

If you would like, I could help you out on some code-cleanup like in this PR.

I found that not all entities had a device, and that not all parameters were consistent for each device. That's why I moved device-creation to __init.py__ so there is more uniformity and easier maintenance.

If you like this kind of work, I can also look into for example room/cat assignings. These also have various implementations.

JoDehli commented 1 month ago

Not all entries should have a device. If I have time I look into the changes. But as I mentioned I am working on a complete new implementation. Until that I have to manually merge changes. This is a lot of work and maybe we can wait until this is finished.

JoDehli commented 1 month ago

If you make a pull request you must first pull the latest version.ni saw that it is based on a older version of the master branch.

gigatexel commented 1 month ago

If you make a pull request you must first pull the latest version.ni saw that it is based on a older version of the master branch.

Are you sure? I synced before branching. Github says its not behind.

image

gigatexel commented 1 month ago

Not all entries should have a device. If I have time I look into the changes. But as I mentioned I am working on a complete new implementation. Until that I have to manually merge changes. This is a lot of work and maybe we can wait until this is finished.

No big deal to wait 👍