search

JoDehli / PyLoxone

Python Loxone binding
Apache License 2.0
183 stars 41 forks source link

On initial setup all button show as on/off switches #281

Closed PaulSinnema closed 1 month ago

PaulSinnema commented 2 months ago

Describe the bug

First off, nice job you did. On initial setup all switches show up as on/off switches. Many of my 'virtual inputs' are push buttons.

Firmware of your Miniserver

15.0.5.29

HomeAssistant install method

HACS

Version of HomeAssistant

2024.3.3 (LinknLink iSG).

Version of Pyloxone

0.6.10

Update pyloxone

I downloaded if via HACS.

Log

Settings for the log can be found on the main page under the section Log Configuration

JoDehli commented 2 months ago

@PaulSinnema I know this is a bug which I tried to fix but with no success. On initial setup you must restart once.

PaulSinnema commented 2 months ago

Hi Joachim,No, they all stay on/off buttons after restart.Regards,PaulOn 29 Jun 2024, at 18:22, Joachim D. @.***> wrote: @PaulSinnema I know this is a bug which I tried to fix but with no success. On initial setup you must restart once.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

PaulSinnema commented 2 months ago

Hi Joachim,

I’m not a py developer but I can read code (I’m a .Net developer). In you switch.py I see this code:

    if switch_entity["type"] in ["Pushbutton", "Switch"]:

        switch_entity.update(

            {

                "room": get_room_name_from_room_uuid(

                    loxconfig, switch_entity.get("room", "")

                ),

                "cat": get_cat_name_from_cat_uuid(

                    loxconfig, switch_entity.get("cat", "")

                ),

                "config_entry": config_entry,

            }

        )

        new_push_button = LoxoneSwitch(**switch_entity)

        entities.append(new_push_button)

Doesn’t cause all switches and pushbuttons to be the same?

Regards,

Paul Sinnema

From: Joachim D. @.> Sent: zaterdag 29 juni 2024 18:22 To: JoDehli/PyLoxone @.> Cc: PaulSinnema @.>; Mention @.> Subject: Re: [JoDehli/PyLoxone] [Bug]: On initial setup all button show as on/off switches (Issue #281)

@PaulSinnema https://github.com/PaulSinnema I know this is a bug which I tried to fix but with no success. On initial setup you must restart once.

— Reply to this email directly, view it on GitHub https://github.com/JoDehli/PyLoxone/issues/281#issuecomment-2198250925 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAMESOC5B76QC7RAXCVSF3ZJ3NLJAVCNFSM6AAAAABKDDKFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGI2TAOJSGU . You are receiving this because you were mentioned.Message ID: @.***>

JoDehli commented 2 months ago

@PaulSinnema now I understood what you meant. In home assistant we do not have push buttons. At least not when I started this integration. At that time we had only switches and no helpers etc.

Does the switches work?

PaulSinnema commented 2 months ago

Yes the switch works

From: Joachim D. @.> Sent: zondag 30 juni 2024 21:40 To: JoDehli/PyLoxone @.> Cc: PaulSinnema @.>; Mention @.> Subject: Re: [JoDehli/PyLoxone] [Bug]: On initial setup all button show as on/off switches (Issue #281)

@PaulSinnema https://github.com/PaulSinnema now I understood what you meant. In home assistant we do not have push buttons. At least not when I started this integration. At that time we had only switches and no helpers etc.

Does the switches work?

— Reply to this email directly, view it on GitHub https://github.com/JoDehli/PyLoxone/issues/281#issuecomment-2198661445 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAMESPDPVS3N2H2F3VLNHLZKBNJXAVCNFSM6AAAAABKDDKFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGY3DCNBUGU . You are receiving this because you were mentioned.Message ID: @.***>

PaulSinnema commented 2 months ago

The switch goes on and off and triggers the event. I think it’s just the presentation of the switch that should change, see attached video.

From: Joachim D. @.> Sent: zondag 30 juni 2024 21:40 To: JoDehli/PyLoxone @.> Cc: PaulSinnema @.>; Mention @.> Subject: Re: [JoDehli/PyLoxone] [Bug]: On initial setup all button show as on/off switches (Issue #281)

@PaulSinnema https://github.com/PaulSinnema now I understood what you meant. In home assistant we do not have push buttons. At least not when I started this integration. At that time we had only switches and no helpers etc.

Does the switches work?

— Reply to this email directly, view it on GitHub https://github.com/JoDehli/PyLoxone/issues/281#issuecomment-2198661445 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAMESPDPVS3N2H2F3VLNHLZKBNJXAVCNFSM6AAAAABKDDKFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGY3DCNBUGU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABAMESIR4QPPSR4ULT2CEH3ZKBNJXA5CNFSM6AAAAABKDDKFC2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUDBTUUK.gif Message ID: @. @.> >

JoDehli commented 2 months ago

@PaulSinnema There is no video included. At the moment I have no time to change something which is working. I concentrate on bugs and errors. That is why it will not be changed in the near future.

PaulSinnema commented 2 months ago

Hoi Joachim,

Ok, I understand that. The thermostat looks like a bug to me.

Strange that no video is attached. I did send it as an .mp4. I’m sending it again but now as a .zip file.

Regards,

Paul Sinnema

From: Joachim D. @.> Sent: woensdag 3 juli 2024 17:50 To: JoDehli/PyLoxone @.> Cc: PaulSinnema @.>; Mention @.> Subject: Re: [JoDehli/PyLoxone] [Bug]: On initial setup all button show as on/off switches (Issue #281)

@PaulSinnema https://github.com/PaulSinnema There is no video included. At the moment I have no time to change something which is working. I concentrate on bugs and errors. That is why it will not be changed in the near future.

— Reply to this email directly, view it on GitHub https://github.com/JoDehli/PyLoxone/issues/281#issuecomment-2206642373 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAMESKAYFLTALBSHEFDUC3ZKQMT3AVCNFSM6AAAAABKDDKFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGY2DEMZXGM . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABAMESJBTDQTG6GS652JQVDZKQMT3A5CNFSM6AAAAABKDDKFC2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUDQ2YMK.gif Message ID: @. @.> >

JoDehli commented 1 month ago

@PaulSinnema please try the newest version of pyloxone. With the help of @gigatexel pyloxone should show the right representation of the entity.