mean_stdv refactor - Githubissues

JoFrhwld / FAVE

A repository for maintaing the fave-align and fave-extract toolkits

GNU General Public License v3.0

114 stars 37 forks source link

mean_stdv refactor #77

Closed JoFrhwld closed 1 year ago

JoFrhwld commented 1 year ago

The code in mean_stdv() should be refactored with numpy https://github.com/JoFrhwld/FAVE/blob/ce2c5cfa2279f771e083532ce467db167f538873/fave/extractFormants.py#L1068

chrisbrickhouse commented 1 year ago

Good first issue:

[ ] Write a test for the current output with lots of test cases
[ ] Remove existing code and replace with numpy calls
[ ] Ensure that the tests still pass, proving that the function output is identical

DerMoehre commented 1 year ago

Hi, I wrote a test for testing the existing code in extractFormants.py It works locally, but fails if I try to create a pull request here on GitHub and somehow, it wants to add these code to the open pull request "Added badges to README". Is there a way to create another PR?

JoFrhwld commented 1 year ago

Closed with #84