search

JoFrhwld / FAVE

A repository for maintaing the fave-align and fave-extract toolkits
GNU General Public License v3.0
114 stars 37 forks source link

added a test file for mean_stdv (extractFormants) #81

Closed DerMoehre closed 1 year ago

DerMoehre commented 1 year ago

It is the test file for the current solution in your code.

Is there a way, how I can choose the files for the PR? It always wants to add these 5 files and not just the test_ If so, I will revert this PR and do it again. Maybe it comes from the mess before

JoFrhwld commented 1 year ago

@DerMoehre I think I'd like to add some additional test cases here to reflect how I think mean_stdv() ought to work with relation to the rest of the code. If it's ok with you, I'll fetch your branch, add those cases in, then send you a pull request. After you merge that, those changes should wind up in this PR.

@chrisbrickhouse the test cases I'm going to add will fail even after we fix up the github actions. I'm adding these specifically to drive the refactor of mean_stdv

DerMoehre commented 1 year ago

@JoFrhwld okay :) I never did a PR but it sounds good :) After you added some more test cases, I will try to modify the main code to use numpy.

DerMoehre commented 1 year ago

Now that I merged your PR in the repository, what should I do next? :-D Merge it again with a PR to dev?