search

JoFrhwld / FAVE

A repository for maintaing the fave-align and fave-extract toolkits
GNU General Public License v3.0
114 stars 37 forks source link

Workflows install and cache dependencies, use poetry #83

Closed chrisbrickhouse closed 1 year ago

chrisbrickhouse commented 1 year ago

Update poetry lock and pyproject.toml with the pytest and flake8 dependencies used by the CI workflow. Update the workflow jobs so that they install dependencies like numpy, and use poetry to run tests and linting.

JoFrhwld commented 1 year ago

Do we need to merge this all the way into master to get the checks to start passing?

Also, I’d been holding off with reviewing & merging this until I could get around to fixing things with the docs branches, since I think a lot of those changes are actually in this PR, but I think the changes I’d’ve wanted to get accurately reflected in doc-fix are in this PR anyway.

chrisbrickhouse commented 1 year ago

Do we need to merge this all the way into master to get the checks to start passing?

I don't think so. As long as future PRs are based on this one, it should run the proper checks.

I’d been holding off with reviewing & merging this until I could get around to fixing things with the docs branches, since I think a lot of those changes are actually in this PR

I actually didn't realize that the doc changes were included here, and I intended for this to be atomic. I guess my dev branch and your dev branch diverged. I'll revert and submit a new PR to keep the commit clean, especially since it involves major changes to the lock file and docs that really shouldn't be mixed.