JoFrhwld / FAVE

A repository for maintaing the fave-align and fave-extract toolkits
GNU General Public License v3.0
114 stars 37 forks source link

[BUG]: rU is renamed in python3.11 onwards #99

Open caitlin91 opened 2 months ago

caitlin91 commented 2 months ago

Did you search for similar bugs?

What happened?

getting an error "valueerror invalid mode 'rU'"

Expectations?

running extractFormants.py to produce vowel extraction

Steps To Reproduce

python 3.12 Windows 11 Pro

fave installed via "python3 -m pip install fave" run from Windows command line fave-extract AudioFileName.wav TextGridFileName.TextGrid OutputFileName

riffing off this answer https://stackoverflow.com/questions/74715990/node-gyp-err-invalid-mode-ru-while-trying-to-load-binding-gyp replacing 'rU' with 'r' in both extractFormants.py and praat.py seems to fix the problem.

robertlennon50 commented 1 month ago

Hi @caitlin91 I had the same issue (Windows 11 Home, Python 3.12.3), and your suggested bug fix worked for me too, thanks :) Note: after making this change I then also got the error "AttributeError: module 'fave.extract.plotnik' has no attribute 'plt_ipa'". To fix this I just commented out the line "plotnik.plt_ipa(vm.cd),", which appears twice, on lines 1434 and 1535 of extractFormants.py. To ensure the output file has the correct number of columns, I then also removed the term " 'plt_vclass', " in two locations. This means you won't get the vowel classification in the output, but everything else should now work - perhaps this can be addressed in a future release!