JoG-Dev / cleanrip

Automatically exported from code.google.com/p/cleanrip
0 stars 0 forks source link

adds "-disc2" to name of every rip following a disc 2 of 2-disc GC game during same rip session #39

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Rip a 2-disc game (Metal Gear Two Snakes, GoldenEye Rogue, etc...)
2. Rip another 2-disc game, or any other single disc games
3. check files on harddrive, note added "-disc2" on filename, multiple 
("-disc2-disc2") if more than one 2-disc game was ripped during the same session

What is the expected output? What do you see instead?
Expected: filename.iso (single disc rip that followed rip of 2-disc game during 
same session)

Result: "filename-disc2.iso" or "filename-disc2-disc2.iso" (as well as the 
dumpinfo files and BCA)

What version of the product are you using? On what operating system?
1.0.5 on Wii to rip GC games collection

Please provide any additional information below.
I've this program to complete rips of all my Wii and GC games previously 
without issue. Thanks! However, this was my first attempt of ripping the two 
2-disc games I have in my collection, both during a single ripping session. The 
games (single disc) that I ripped first came out named correctly, but *all* 
titles following the first 2-disc rip ("Metal Gear Solid The Two Snakes") had 
"-disc2" added to the filename, and all titles following the second 2-disc rip 
("GoldenEye Rogue Agent") had "-disc2-disc2" added to the filename.

Original issue reported on code.google.com by DQHud...@gmail.com on 16 Mar 2013 at 10:15

GoogleCodeExporter commented 8 years ago
That behaviour is actually not a bug. The application uses a dump counter that 
stores how many discs have been ripped on a single session, and appends the 
disc number to the filename. I'm pretty much sure that if you tried to make a 
third rip, it would be named "filename-disc3.iso" or "filename-disc2-disc3.iso".

The only way to disable this is by recompiling the source code with that code 
commented or removed.

Original comment by pabloacurielz@gmail.com on 17 Jul 2013 at 10:18

GoogleCodeExporter commented 8 years ago
I don't know what you're smoking but that's not how it works at all. It was a 
strncpy/sprintf bug fixed in r35.

Original comment by tue...@hotmail.com on 29 Jul 2013 at 7:47