Missing return statement

JoJoJet / bevy-trait-query

adds trait queries to the bevy game engine

Apache License 2.0

71 stars 15 forks source link

Missing return statement #27

Closed bzm3r closed 1 year ago

JoJoJet commented 1 year ago

I'm good with merging this, even with miri failing.

Hopefully it's just a spurious failure, and will resolve itself in a future nightly. Even if there really is unsoundness here, this PR definitely doesn't make anything worse, so I won't block on miri.

JoJoJet commented 1 year ago

Heh, apparently this issue wasn't causing unsoundness, because One<T>::set_table never gets called. Still can't hurt to merge this, though :)