search

JoJoJet / bevy-trait-query

adds trait queries to the bevy game engine
Apache License 2.0
65 stars 11 forks source link

Added/Changed detection #30

Closed bzm3r closed 1 year ago

bzm3r commented 1 year ago

ImplementsAdded/Changed functionality for bevy-trait-query!

Closes: #23

What is needed to for this to go out of draft status:

alice-i-cecile commented 1 year ago

@bzm3r @JoJoJet would you like me to adopt this? <3

JoJoJet commented 1 year ago

I am okay with that :)

Shatur commented 1 year ago

@alice-i-cecile are you still planning to tackle this?

alice-i-cecile commented 1 year ago

No: I'm not currently using bevy-trait-query in any of my projects.

Shatur commented 1 year ago

Thanks for letting me know. Then I will try to adopt this.

Shatur commented 1 year ago

A lot of things changed in Bevy related to change detection: https://github.com/bevyengine/bevy/pull/6547 https://github.com/bevyengine/bevy/pull/6681 https://github.com/bevyengine/bevy/pull/7905 Not sure how to properly update some places of this PR. @JoJoJet Maybe you can take a look since you the author of the last one? :)

bzm3r commented 1 year ago

This was rebased later on, and the comments here will be addressed through review there: https://github.com/JoJoJet/bevy-trait-query/pull/42