JoMingyu / google-play-scraper

Google play scraper for Python inspired by <facundoolano/google-play-scraper>
MIT License
757 stars 206 forks source link

permissions: Ensure permission is not null before adding it #101

Closed yshalsager closed 3 years ago

yshalsager commented 3 years ago

Some apps like this app permissions' data contain empty elements in its list. This results in retuning dict with None name and value which should be handled correctly.

Before my change:

{None: None, 'Device & app history': ['read sensitive log data'], 'Photos/Media/Files': ['modify or delete the contents of your USB storage', 'read the contents of your USB storage'], 'Storage': ['modify or delete the contents of your USB storage', 'read the contents of your USB storage'], 'Other': ['full network access', 'prevent device from sleeping', 'view network connections'], 'Uncategorized': ['receive data from Internet']}

After change:

{'Device & app history': ['read sensitive log data'], 'Photos/Media/Files': ['modify or delete the contents of your USB storage', 'read the contents of your USB storage'], 'Storage': ['modify or delete the contents of your USB storage', 'read the contents of your USB storage'], 'Other': ['full network access', 'prevent device from sleeping', 'view network connections'], 'Uncategorized': ['receive data from Internet']}
JoMingyu commented 3 years ago

Thanks you. I'll release it asap after fix some tests.

JoMingyu commented 3 years ago

It included at version 1.0.2 release. Thanks to your contribution!