Closed fredszaq closed 8 years ago
I need a fix too...
It's actually a incompatibility between textAllCaps and spans. See https://code.google.com/p/android/issues/detail?id=67509
I'm not sure what I should do about it :
allCaps
usable on IconTextView
, IconButton
, etc.. instead of the original one. That would still break integration with other libraries that use Spans
.textView.setText("hello {icon}".toUpperCase())
without breaking Iconify, by doing toLowerCase
on icon keys internally. But that means icon keys would become case-independant, which is a (minor) breaking change.@fredszaq @pinfrederic WDYT?
Well I think I'll take the third option after all, there's no good way to solve this.
It seems to be the best option yes ! Le 1 mars 2016 7:58 AM, "Joan Zapata" notifications@github.com a écrit :
Well I think I'll take the third option after all, there's no good way to solve this.
— Reply to this email directly or view it on GitHub https://github.com/JoanZapata/android-iconify/issues/124#issuecomment-190582802 .
Obviously this is your own project and I respect every decision you make about it, but when this bug bites you it bites you hard. At least for me this is a deal breaker.
Making icon keys case insensitive doesn't seem to be too bad an option in my opinion. Perhaps you can think about it one more time :) ?
When adding
android:textAllCaps="true"
to a text view with icons, the icons are not displayed, a stroked square or nothing at all is displayed depending on the device used