android:textAllCaps="true" causing icons not to display

JoanZapata / android-iconify

Android integration of multiple icon providers such as FontAwesome, Entypo, Typicons,...

http://joanzapata.com/android-iconify

Other

3.93k stars 527 forks source link

android:textAllCaps="true" causing icons not to display #124

Closed fredszaq closed 8 years ago

fredszaq commented 8 years ago

When adding android:textAllCaps="true" to a text view with icons, the icons are not displayed, a stroked square or nothing at all is displayed depending on the device used

pinfrederic commented 8 years ago

I need a fix too...

JoanZapata commented 8 years ago

It's actually a incompatibility between textAllCaps and spans. See https://code.google.com/p/android/issues/detail?id=67509

I'm not sure what I should do about it :

Add a custom attribute allCaps usable on IconTextView, IconButton, etc.. instead of the original one. That would still break integration with other libraries that use Spans.
Allow you to easily uppercase your texts using textView.setText("hello {icon}".toUpperCase()) without breaking Iconify, by doing toLowerCase on icon keys internally. But that means icon keys would become case-independant, which is a (minor) breaking change.
Nothing

@fredszaq @pinfrederic WDYT?

JoanZapata commented 8 years ago

Well I think I'll take the third option after all, there's no good way to solve this.

fredszaq commented 8 years ago

It seems to be the best option yes ! Le 1 mars 2016 7:58 AM, "Joan Zapata" notifications@github.com a écrit :

Well I think I'll take the third option after all, there's no good way to solve this.

— Reply to this email directly or view it on GitHub https://github.com/JoanZapata/android-iconify/issues/124#issuecomment-190582802 .

jlhonora commented 8 years ago

Obviously this is your own project and I respect every decision you make about it, but when this bug bites you it bites you hard. At least for me this is a deal breaker.

Making icon keys case insensitive doesn't seem to be too bad an option in my opinion. Perhaps you can think about it one more time :) ?