JoanZapata / android-iconify

Android integration of multiple icon providers such as FontAwesome, Entypo, Typicons,...
http://joanzapata.com/android-iconify
Other
3.93k stars 527 forks source link

Too many semicolons in documentation code sample and missing module #131

Closed MarcinOrlowski closed 8 years ago

MarcinOrlowski commented 8 years ago

In docs, you write:

public class MyApplication extends Application {
     @Override
     public void onCreate() {
          super.onCreate();
          Iconify
                .with(new FontAwesomeModule())
                .with(new EntypoModule())
                .with(new TypiconsModule());
                .with(new MaterialModule());
                .with(new MeteoconsModule());
                .with(new WeathericonsModule());
                .with(new SimpleLineIconsModule());
                .with(new IoniconsModule());
     }
}

while is incorrect due to too much semi colons. It also lacks reference to MaterialCommunityModule. Correct version should look like this:

public class MyApplication extends Application {
    @Override
    public void onCreate() {
        super.onCreate();
        Iconify
            .with(new FontAwesomeModule())
            .with(new EntypoModule())
            .with(new TypiconsModule())
            .with(new MaterialModule())
            .with(new MaterialCommunityModule())                 
            .with(new MeteoconsModule())
            .with(new WeathericonsModule())
            .with(new SimpleLineIconsModule())
            .with(new IoniconsModule());
    }
}
JoanZapata commented 8 years ago

Fixed by #140 (thanks @msneujink)