search

JoanZapata / android-iconify

Android integration of multiple icon providers such as FontAwesome, Entypo, Typicons,...
http://joanzapata.com/android-iconify
Other
3.93k stars 527 forks source link

Please add ImageView #132

Open CROSP opened 8 years ago

CROSP commented 8 years ago

Please add Image View that can be used from xml with custom attributes, I have created custom and can share it, but it would be better to have it in library core. It is very useful, because I don't need to specify default image from the code.

JoanZapata commented 8 years ago

I already thought about that but I don't see any difference with an IconTextView with android:text="{any-icon}". Do you?

mauriciogior commented 8 years ago

@JoanZapata It actually makes sense, since it would be rendered by preview and it automatically scales according to its size.

MarcinOrlowski commented 8 years ago

@mauriciogior You mean you wan to be able to use iconify's icon as placeholder unless final the image is set? If so you can extend ImageView and then internally read i.e. android:text and use setImageDrawable() to set generated IconDrawable as your placeholder.