search

JoanZapata / android-iconify

Android integration of multiple icon providers such as FontAwesome, Entypo, Typicons,...
http://joanzapata.com/android-iconify
Other
3.93k stars 527 forks source link

Add pulsing spin animation #148

Open 1zaman opened 8 years ago

1zaman commented 8 years ago

The Font Awesome CSS framework has a pulse animation that rotates an icon in 8 steps, which matches the structure of it's pulsing spinner. This has been implemented with the "pulse" token here. Since Font Awesome seems to have the only dotted pulsing spinner out of the current font set, this seems a reasonable generic implementation at the moment. If at some point spinners with different pulses need to be handled, then a pulse property can be introduced for the icons, with 8 as the default count.

1zaman commented 8 years ago

Note that I have a few pull requests open at the moment, and they all somewhat affect each other. My develop branch can be consulted (and used) in merging multiple of these pull requests, as I have merged all of them these with appropriate summary in the merge commit messages. Alternatively, if you merge them one at a time, then I'll rebase the others to the merged state.

andreasschiestl commented 8 years ago

please merge this feature. It helps to make Apps that are consistent between Web and Android.