search

JoanZapata / android-iconify

Android integration of multiple icon providers such as FontAwesome, Entypo, Typicons,...
http://joanzapata.com/android-iconify
Other
3.93k stars 527 forks source link

AppCompat support #169

Open SteveYurka opened 8 years ago

SteveYurka commented 8 years ago

It may be worth considering changing the widgets to their AppCompat versions, such as AppCompatTextView.

I changed the subclasses to their AppCompat counterparts, and all of the other functionality still works perfectly.

There is some useful features out now in AppCompat 23, such as being able to use setBackgroundTint to change the color of a drawable which otherwise requires API 21.

However this will probably then add that dependency to a bunch of people who don't need it

JoanZapata commented 8 years ago

Thanks for the suggestion. Unfortunately the extra dependency makes it not worth it, the only way to do it without interfering with the current users would be to put those classes in a new library based on Iconify and AppCompat, which sounds overkill for now.