Add some useful methods: setEnabled, setOnClickListener, setTag, setChec... - Githubissues

JoanZapata / base-adapter-helper

Abstraction for the usual BaseAdapter "ViewHolder" pattern

http://joanzapata.com/base-adapter-helper/

Other

1.76k stars 530 forks source link

Add some useful methods: setEnabled, setOnClickListener, setTag, setChec... #37

Closed jiegec closed 10 years ago

jiegec commented 10 years ago

Add some useful methods: setEnabled, setOnClickListener, setTag, setChecked, setAdapter. I may add some more if i have time.

JoanZapata commented 10 years ago

Hi @jiegec , thanks for the pull request. Unfortunately I can't merge it as it is for a few reasons:

There's 4 commits, one of them is a duplicate, one other is a merge.. Why is that ? Please provide clean commits.
You changed the signature of retrieveView, I don't see any good reason to do so.
Please don't change the versions in the README, in a commit which is not related to it. I'll update the versions in a separate one.

I close this pull request but I hope you'll provide a new one fixing those minor issues. Thanks for your work :)