nus-pe-bot
commented
10 months ago Team's Response
The drug could not be added in the first place, thus giving the correct error command saying it should be the format of 3 letters followed by 3 numbers. From this error command, the user would have known that there would be no drugs in the list with incorrect format.
Using the delete command would result in the error command "Drug not found in the inventory", as it is true that no drugs with that serial number exist. This is similar to the find command, as there are no drugs with that serial number.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Based on the UG, serial numbers like "PANA002" and "PAN1234" can successfully delete the drug or find the drug (implying that it could be added). The examples in stockLevel also imply that "HIS9447" and "PARC347" can be added while the add drug command restricts the serial number to be three capital letters followed by three numbers. This shows that the intended serial number format was different for add, delete, and find.
Also, it would be clearer to return an error message saying "Serial number should be in the format of three capital letters followed by three numbers (e.g., ABC123)", just like the add command, instead of the general error messages like "Drug not found in the inventory." and "No drugs found with the specified criteria.". If not, the user would need to try adding a drug with invalid serial number until the user finally realises the drug could not be found or deleted because he accidentally mistyped an additional character, not because they were not in the inventory. This could also be a bug in the specificity of error message.
Steps:
Expected: Serial number should be in the format of three capital letters followed by three numbers (e.g., ABC123).
Actual: Drug not found in the inventory. It seems like delete and find's serial number can be ABC1233 but adding does not allow for ABC1233 in the first place.