JoaoLopesF / RemoteDebug

Library for Arduino to debug projects over WiFi, with web app or telnet, with print commands like Serial Monitor
MIT License
614 stars 127 forks source link

Way of setting Telnet port #24

Closed PjotrekSE closed 6 years ago

PjotrekSE commented 6 years ago

Hi there, and thanx for this nice addition. Worx like a charm. For reasons of obfuscating, I want to set the Telnet port to something other than 23. I designed a solution for this, see included files. I also changed the word 'setted' into 'set' in several places, hope you don't mind. Keep up the good work! PjotrekSE

RemoteDebug.cpp.txt RemoteDebug.h.txt

JoaoLopesF commented 6 years ago

Hi, thanks for your suggestion, I will do this soon

Regards,

Joao

JoaoLopesF commented 6 years ago

Hi, Your code is very good, I like use of pointer to WiFiServer . I apreciate your suggestion, but how this is used once time in project, is more simple, modify the port in RemoteDebug.h. In the next version, I can modify it for project:

define TELNET_PORT 1000

include "RemoteDebug.h"

It is a very good suggestion to increase security

I change the "setted"s, it will in next version I modify the initial comments in RemoteDebug.h, as exists in your version

Thanks a lot