search

JoaoMGomes / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

Update README for including third party gtest package in version 0.6.2 #232

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Follow steps on readme to build libjingle 0.6.2
2.
3.

What is the expected output? What do you see instead?

Libjingle should build. It fails because of a dependency to gunit in 
third_party library. The README talks about installing expat and srtp but says 
nothing about gunit.

What version of the product are you using? On what operating system?

Mac OS, libjingle 0.6.2

Please provide any additional information below.

Copying gtest-1.6.0 into third party ends up with some dynamic cast errors too. 
Not sure if that was something wrong on my side, or if gtest got compiled with 
different options.

Original issue reported on code.google.com by prakashr...@gmail.com on 23 Oct 2011 at 6:17

GoogleCodeExporter commented 9 years ago 
The README says:

Finally, download and install the unit test framework from
    http://code.google.com/p/googletest/downloads/list
    To install it, just unzip the package and put the file folder under
    /talk/third_party/ directory and rename it from "gtest-x.x.x" to "gtest",
    so that your folder structure looks like:
    /talk/third_party/gtest/...

Did you change the folder name to gtest?

Here I could compile without problems, but I'm using Ubuntu 10.04, 32 bits, so 
I don't know if this is a Mac Os related problem.

Original comment by diego.cd...@gmail.com on 24 Oct 2011 at 12:16

GoogleCodeExporter commented 9 years ago 
Taking advantage of this topic, on issue 170 I wrote:

Jun, thanks for updating the README but I would like to suggest two more 
changes:
First, the line:
* On Linux, you need to install libssl-dev, libasound2-dev and gtk+2.0.
Should appear before the line:
* Third, go to the talk/ directory and run $path_to_swtoolkit/hammer.sh. Run
    $path_to_swtoolkit/hammer.sh --help for information on how to build for
    different modes.
Just exchange these lines because if you is following the instructions in order 
you will try to compile libjingle before installing those packages and will get 
an error.
Second I think you should put the real package name for gtk instead of gtk+2.0 
because you can't execute sudo apt-get install gtk+2.0 (but you can type sudo 
apt-get install libssl-dev libasound2-dev). I installed libgtk2.0-dev. Thanks.

Jun answered:

Thanks for the feedback. I'll fix the README in the next release.

So he agreed but I think he forgot to update the READEME. It would be nice this 
update in the next release. Thanks.

Original comment by diego.cd...@gmail.com on 24 Oct 2011 at 12:21

GoogleCodeExporter commented 9 years ago 
You are right. Not sure what i was smoking, i had some older version too, so 
most probably was staring at the wrong file. This can be closed. The README 
indeed has notes on gtest.

Original comment by prakashr...@gmail.com on 25 Oct 2011 at 12:51

GoogleCodeExporter commented 9 years ago 
Sorry for not able to get this fixed sooner. I've submitted a change for 
review. The README file should be fixed in 0.6.3.

Original comment by jun...@google.com on 27 Oct 2011 at 8:56

GoogleCodeExporter commented 9 years ago 
No problem, this is a low priority issue. I just thought that it would help 
other guys to compile libjingle easier. Thanks Jun.

Original comment by diego.cd...@gmail.com on 28 Oct 2011 at 12:34

GoogleCodeExporter commented 9 years ago 
You are welcome. Thanks for the reminder. This is a low-hanging fruit. It only 
takes few minutes, so I made the fix.

Original comment by jun...@google.com on 28 Oct 2011 at 4:01