search

JoaquinAmatRodrigo / skforecast

Time series forecasting with machine learning models
https://skforecast.org
BSD 3-Clause "New" or "Revised" License
996 stars 113 forks source link

Repeating SARIMAX .summary() bug fix #636

Closed tyg3rr closed 4 months ago

tyg3rr commented 4 months ago

https://github.com/JoaquinAmatRodrigo/skforecast/pull/635

tyg3rr commented 4 months ago

I'm not sure what's going on here! This is my first major PR. Did you want me to PR a branch other than master?

JoaquinAmatRodrigo commented 4 months ago

Hi @tyg3rr, Please, change the target branch to 0.12.x

tyg3rr commented 4 months ago

@JoaquinAmatRodrigo it's giving me the following error: There are no new commits between base branch '0.12.x' and head branch 'master'

JoaquinAmatRodrigo commented 4 months ago

I have no idea what is going wrong XD Let me close the PR and let's try with a new one

tyg3rr commented 4 months ago

Here's what I see trying to merge with 0.12.x image

Here's what I see trying to merge with master image

It seems like my merge with master would also introduce all of the other changes in 0.12.x between the last merge and my merge with 0.12.x. I think those changes are causing the unit test failures?