search

Jobeso / react-native-story-share

Share your images to instagram and snapchat stories with react native.
107 stars 54 forks source link

Fix podspec and Swift issue #32

Closed kyleclegg closed 4 years ago

kyleclegg commented 4 years ago

Fixes an issue with the podspec file and updates Swift code for latest compatibility.

kyleclegg commented 4 years ago

@Jobeso would love to see this merged! Would allow me (and other Cocoapods users) to use react-native-story-share directly rather than my forked version.

ciawalsh commented 4 years ago

Bumping as a reminder! 😄 @Jobeso

Jobeso commented 4 years ago

@kyleclegg thanks for your work @ciawalsh thanks for the reminder

Sorry for the waiting time, both of you. Just published 0.4.1 including this fix.

franznkemaka commented 3 years ago

Hi @kyleclegg,

what was the exact issue with this? I'm currently using Swift5 and it won't work with these changes, I have to make a regression of your PR before it works. Do you have an idea, why it is happening?

Thanks

kyleclegg commented 3 years ago

The issue was UIImage's pngData API changed slightly and would no longer compile using the old syntax.

franznkemaka commented 3 years ago

Thanks for the reply @kyleclegg