Closed franznkemaka closed 3 years ago
Great that you investigated. https://github.com/jobeso/react-native-story-share/commit/457542b0fb5f967e49a4659a44cb977f44205ad2 was merged to fix an issue, reverting could break this again. Did you check that? Thanks for you help here.
Great that you investigated. 457542b was merged to fix an issue, reverting could break this again. Did you check that? Thanks for you help here.
Hi @Jobeso, it looks like it depends on the Swift version. I'm currently using React Native 0.63.1 with Swift 5 that's why it is not working. What is the Swift support version for the library?
Hi @Jobeso , any update?
If I understood correctly, this PR supports Swift 5 and the current code a different version of Swift. I'm not sure which is the best to support then.
If I understood correctly, this PR supports Swift 5 and the current code a different version of Swift. I'm not sure which is the best to support then.
Hello @Jobeso, thanks for replying, exactly. The old version that this without this PR won't work with react native 0.62+ (at least on my own end). Here is what it does in a nutshell
I was unable to build using React Native 0.63.1, due to a couple of issues.
dyld: Library not loaded: @rpath/PINCache.framework/PINCache Referenced from: /Users/.../Library/Developer/CoreSimulator/Devices/A67AEA68-7434-4B77-B259-CEF24F8D2F04/data/Containers/Bundle/Application/B09D6537-A239-4252-8EEE-05B8949C4FC0/Example.app/Frameworks/SCSDKBitmojiKit.framework/SCSDKBitmojiKit Reason: image not found
Definitely fixes https://github.com/Jobeso/react-native-story-share/issues/13 as mentioned here: https://github.com/react-native-community/react-native-share/pull/575#issuecomment-540821396
I'm not 100% sure it will work on other Swift versions, but it definitely works for me. Meanwhile, I'm currently my forked in my package.json.
Thanks, Franz