search

Jobeso / react-native-story-share

Share your images to instagram and snapchat stories with react native.
107 stars 54 forks source link

Use root project build.gradle configurations #7

Closed franznkemaka closed 5 years ago

franznkemaka commented 5 years ago

Use root app compileSdkVersion, buildToolsVersion, minSdkVersion & targetSdkVersion to avoid error when running $ gradlew assembleRelease

Jobeso commented 5 years ago

Hey, thanks for your PR. Code looks good, great contribution. I'll test it and then create a new release with it.

franznkemaka commented 5 years ago

Hey, thanks for your PR. Code looks good, great contribution. I'll test it and then create a new release with it.

Thank you! it would be nice, because everytime i run npm install it reuses the old build.gradle configs. Nice library, simple & functional!

Jobeso commented 5 years ago

v0.4.0 is live containing your changes, thanks for the PR

franznkemaka commented 5 years ago

v0.4.0 is live containing your changes, thanks for the PR

Thanks very much!