search

Jobeso / react-native-whatsapp-stickers

Integrate sticker packs for WhatsApp with your react-native app
Other
81 stars 30 forks source link

Android Activities #14

Closed vincekruger closed 8 months ago

vincekruger commented 5 years ago

I've updated the android activity monitor to include more of the error messages from the stickers module.

kesepara commented 5 years ago

@vincekruger did you manage to add this plugin to iOS ?

vincekruger commented 5 years ago

Yup. I added it manually, but I haven't done any further integration with iOS just yet.

kesepara commented 5 years ago

@vincekruger okay. i couldn't do that. error happens every time. can you please let me know if you can do the integrations?

vincekruger commented 5 years ago

@vincekruger okay. i couldn't do that. error happens every time. can you please let me know if you can do the integrations?

What errors are you getting?

kesepara commented 5 years ago

@vincekruger okay. i couldn't do that. error happens every time. can you please let me know if you can do the integrations?

What errors are you getting?

i think there are problems with Integration part of installation. because i did the "react-native link" and there was no error happened. but also i can't reach the createStickerPack function etc. then i did the integration part, and it couldn't find WebP framework.

It throws this error:

ld: framework not found WebP clang: error: linker command failed with exit code 1 (use -v to see invocation)

vincekruger commented 5 years ago

The problem is not the stickers project. iOS doesn't support WebP out the box. Here is a great article explaining all of this and how to add support for WebP to iOS

https://medium.com/@tgpski/react-native-webp-reducing-bundle-binary-sizes-increase-speed-with-webp-image-format-aa9b1aa11405

Jobeso commented 5 years ago

Great PR, very valuable! I look into it and merge it then.

Probably it makes sense to add an example project to the repo for easier testing in the future.

vincekruger commented 5 years ago

@Jobeso I can do the android one if you do the iOS one. ;)

Jobeso commented 5 years ago

@Jobeso I can do the android one if you do the iOS one. ;)

Sounds good :)

Jobeso commented 5 years ago

@kesepara Like @vincekruger mentioned the WebP framework integration is probably the problem here. There is a section in the integration part of the README about WebP integration. Hope that helps, otherwise feel free to open an issue to get help.

kesepara commented 5 years ago

@kesepara Like @vincekruger mentioned the WebP framework integration is probably the problem here. There is a section in the integration part of the README about WebP integration. Hope that helps, otherwise feel free to open an issue to get help.

Thanks both of you guys @vincekruger @Jobeso . I am going to try these solutions right now.

Jobeso commented 5 years ago

Hey @vincekruger, I finally found the time to test this and look over it. It looks really good and I think it is a great enhancement. Please pull the master and then I can merge this PR. Please make sure you accept the version from master in the package.json. Thanks