search

JocysCom / TextToSpeech

Jocys.com Text To Speech Monitor and WoW Addon - Reads quests and chat messages with text-to-speech voices.
https://www.jocys.com/TTS
GNU Lesser General Public License v3.0
28 stars 11 forks source link

Fixed bugs in AmazonPollyUserControl and #48

Closed robertjawoods closed 3 years ago

robertjawoods commented 3 years ago

While setting up Amazon Polly, I encountered two bugs.

The first being that there was an exception when initially clicking "Speak" due to a voice not being set as default. image

I solved this by invoking the RegionComboBox_SelectedIndexChanged event, however this may not be the ideal way to achieve the goal of fixing this bug. Please suggest any edits you feel necessary.

The second bug was due to the request being expected as SSML, and AmazonPollyUserControl.MessageTextBox.Text not being formatted as such. Using PromptBuilder solves this issue in a way that will work for all use cases. There is the potential to use string concatenation/interpolation, however I am not sure how special characters would be encoded.

EJocys commented 3 years ago

@robertjawoods

Thank you. Merged your fixes into new release: https://github.com/JocysCom/TextToSpeech/releases

Kind regards, Evaldas Jocys

robertjawoods commented 3 years ago

Brilliant! Love the program, been looking for something like this for years, literally.

Not noticed any other issues, but will attempt to fix any if I find them. Thanks for making this, you did a great job 😄

@EJocys