search

JodaOrg / joda-beans

Java library to provide an API for beans and properties.
http://www.joda.org/joda-beans/
Apache License 2.0
143 stars 37 forks source link

Modernize base bean code #391

Closed jodastephen closed 6 days ago

jodastephen commented 1 week ago

Changes refactor the code to Java 21

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago
📝 Walkthrough ## Walkthrough The pull request introduces a series of modifications across multiple classes in the `org.joda.beans` package. Key changes include the adoption of the `var` keyword for local variable type inference, refactoring of equality checks and hash code methods using utility classes, and the use of switch expressions for improved readability. Additionally, several methods have been updated to use pattern matching for `instanceof` checks, streamlining the code. These changes enhance code clarity and maintainability without affecting the existing functionality. ## Changes | File Path | Change Summary | |---------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `src/main/java/org/joda/beans/BeanIterator.java` | Updated variable declarations to use `var`, renamed `current` to `currentBean`, and modified `findChildBeans` method for pattern matching with `instanceof`. | | `src/main/java/org/joda/beans/JodaBeanUtils.java` | Refactored `equalsArray`, `hashCodeArray`, and `toStringArray` methods to use switch expressions. Updated `hashCode` methods for primitive types to use respective utility methods. Simplified `notBlank` and `notEmpty` methods. | | `src/main/java/org/joda/beans/MetaBean.java` | Changed variable declarations in `metaProperty`, `annotations`, `annotation`, and `annotationOpt` methods to use `var`. Updated `annotations` method to return `List.of()` instead of `Collections.unmodifiableList(Arrays.asList())`. | | `src/main/java/org/joda/beans/MetaBeans.java` | Updated variable declarations in `lookup`, `metaBeanLookup`, and `register` methods to use `var`. | | `src/main/java/org/joda/beans/MetaProperty.java` | Changed variable declarations in `annotation` and `annotationOpt` methods to use `var`. | | `src/main/java/org/joda/beans/PropertyPath.java` | Updated local variable declarations in `of`, `get`, and `parse` methods to use `var`. Refactored `equals` method to use pattern matching. | | `src/main/java/org/joda/beans/impl/BasicMetaProperty.java` | Refactored `equals` method to use pattern matching for `instanceof`. | | `src/main/java/org/joda/beans/impl/BasicProperty.java` | Enhanced `equals` and `hashCode` methods to use `Objects` utility class for null-safe comparisons. | | `src/main/java/org/joda/beans/impl/BasicPropertyMap.java` | Simplified `containsKey` method and updated `entrySet` method to use diamond operator and `var`. | | `src/main/java/org/joda/beans/impl/direct/DirectMetaPropertyMap.java` | Updated variable declarations to use `var` and applied pattern matching for `instanceof` checks in multiple methods. | | `src/main/java/org/joda/beans/impl/direct/MinimalMetaBean.java` | Refactored `equals` method to use pattern matching. | | `src/main/java/org/joda/beans/impl/flexi/FlexiBean.java` | Refactored `equals` method to use pattern matching. Added comment to `toMap` method. | | `src/main/java/org/joda/beans/impl/flexi/FlexiMetaBean.java` | Updated `metaPropertyIterable()` and `metaPropertyMap()` methods to use lambda expressions and `var`. | | `src/main/java/org/joda/beans/impl/light/LightMetaBean.java` | Refactored loops to enhanced for-loops and updated `equals` method to use pattern matching. | | `src/main/java/org/joda/beans/impl/map/MapMetaBean.java` | Updated `metaPropertyIterable()` and `metaPropertyMap()` methods to use lambda expressions and `var`. | | `src/main/java/org/joda/beans/impl/reflection/ReflectiveMetaBean.java` | Refactored `equals` method to use pattern matching. | | `src/main/java/org/joda/beans/ser/GuavaSerIteratorFactory.java` | Refactored `createIterable` method to use a switch expression. | | `src/main/java/org/joda/beans/ser/bin/JodaBeanBinReader.java` | Modified `read` method to use try-with-resources for better resource management. | | `.coderabbit.yaml` | Added new path instructions for Java files, specifying guidelines for code review with Java 21 standards, indentation rules, and variable annotation guidelines. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.