search

JodaOrg / joda-time

Joda-Time is the widely used replacement for the Java date and time classes prior to Java SE 8.
http://www.joda.org/joda-time/
Apache License 2.0
4.98k stars 986 forks source link

Adding sq locale #666

Closed ujdhesa closed 2 years ago

ujdhesa commented 2 years ago

Please add sq locale translation to the project. TIA!

hb20007 commented 2 years ago

@ujdhesa, I see that you have some non-ASCII characters in the file. We need to use Unicode escapes in the place of those characters. For example: https://github.com/JodaOrg/joda-time/blob/main/src/main/java/org/joda/time/format/messages_da.properties

hb20007 commented 2 years ago

@ujdhesa Also, the space at the end of lines 3 and 4 shouldn't be there.

ujdhesa commented 2 years ago

@hb2000 Just to be sure, are you talking about “ë” character?

hb20007 commented 2 years ago

@hb2000 Just to be sure, are you talking about “ë” character?

Yes

ujdhesa commented 2 years ago

File edited to comply with your request, @hb20007 . Thank you!

hb20007 commented 2 years ago

File edited to comply with your request, @hb20007 . Thank you!

That doesn't look right. You need to use a Unicode escape. It will look like this: \u9999, where 9999 will actually be the Unicode hex value of this character.

hb20007 commented 2 years ago

@ujdhesa Are you sure the uppercase U will work? (\U)

I am searching for documentation and I see that the U seems to be in lowercase everywhere. For example:

A unicode escape sequence is a backslash followed by the letter 'u' followed by four hexadecimal digits (0-9a-fA-F).

hb20007 commented 2 years ago

@ujdhesa Actually, I'm sure that this is the correct one: \u00EB

For example, you can find it here: https://www.fileformat.info/info/unicode/char/eb/index.htm Under "C/C++/Java source code"

ujdhesa commented 2 years ago

@hb20007 Changed as per your request.

hb20007 commented 2 years ago

@hb20007 Changed as per your request.

You also need to remove the + sign...