search

JodliDev / calendar

GNU Affero General Public License v3.0
16 stars 12 forks source link

Commit composer lockfile in git ? #9

Closed n-peugnet closed 2 years ago

n-peugnet commented 2 years ago

Composer recommends adding the lockfile to the VCS. I know the lockfile will not be used when installing this plugin the recommended way, but this could still be useful for development setup to speedup composer dependency resolving. Otherwise it could be added to the .gitignore (along with the vendor directory).

Edit: after some thinking this could lead to issues when updating the sources from upstream project. It may be better to ignore it.

JodliDev commented 2 years ago

SInce the original project does not have it, I think its best to leave it as is - just to stay in sync as much as possible :)