search

JodyLorah / pe

0 stars 0 forks source link

Diagrams used not optimal #17

Open JodyLorah opened 3 years ago

JodyLorah commented 3 years ago

All the diagrams fail to show the replacement process, which is crucial to further developers if they want to amend that step.

image.png

nus-pe-bot commented 3 years ago

Team's Response

The replacement process is obvious when reading the code. These diagrams are for a higher level of abstraction, as given in the requirements.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Abstracting away does not mean completely not explaining, since there can be 2 ways of implemented the replacement, adding the copy before deleting the original or deleting the original then adding the copy. As stated above, this is crucial to further developers if they want to amend that step.