search

Joe91 / fun-bots

A highly customizable and configurable bot mod for your Venice Unleashed Battlefield 3 server.
https://discord.gg/zNk3qCzk6x
237 stars 45 forks source link

fix: review of `pt_PT.lua` and `pt_PT.js` #239

Closed joao-vitor-souza closed 1 year ago

joao-vitor-souza commented 1 year ago

4c08268: Review of the Portuguese language files pt_PT.lua and pt_PT.js; efce7fe: Instantiating the translator object before the loop, decreasing memory consumption; b326126: I found duplicated lines in the DEFAULT.lua file and decided to remove them; 76db8d1: Styling python scripts according to the Proposal of Enhancement (PEP) 8, removing unused libraries and variables with autoflake, and sorting libraires with isort; c982aee: Closing data base connection in clear_settings.py; 165de12: Static typing all functions to increase robustness against type errors (PEP 484); de57cfa: Uploads a new template for .gitignore that includes: bytecodes, caches, sqlite db logs, venvs...

Joe91 commented 1 year ago

Nice one! Thanks a lot! Would you like to have access to the repository?

joao-vitor-souza commented 1 year ago

Nice one! Thanks a lot! Would you like to have access to the repository?

Sure!

Joe91 commented 1 year ago

I added you to the repository. Are you also on discord? It also works fine to just communicate over github...

Joe91 commented 1 year ago

Feel free to create whatever branch you like. If you are not sure about if it should be merged back into dev, just ask, but feel free to do so if you think it's an improvement.