search

Joe91 / fun-bots

A highly customizable and configurable bot mod for your Venice Unleashed Battlefield 3 server.
https://discord.gg/zNk3qCzk6x
237 stars 45 forks source link

[WIP] general refactoring #241

Closed joao-vitor-souza closed 1 year ago

Joe91 commented 1 year ago

How can we solve the issue, that the module "go_back_to_root" can't be found when using the fun-bots-helper.py ? Should the tools-scripts work standalone or should we focus on the usage in the fun-bots-helper.py?

Joe91 commented 1 year ago

By the way: I really like what you are doing! This looks so much better than before :-)... Thanks a lot!

joao-vitor-souza commented 1 year ago

How can we solve the issue, that the module "go_back_to_root" can't be found when using the fun-bots-helper.py ? Should the tools-scripts work standalone or should we focus on the usage in the fun-bots-helper.py?

I created the folder fun-bots/dev/fun-bots-helper/addons that contains functions that will modularize all the files in tools, now it's working fine. The PR was still in progress and you merged it btw 😅. No need to revert it though (unless you need to use fun-bots-helper.py right now), I will soon make another PR.

Joe91 commented 1 year ago

Ah okay. All fine. I modified the import on some of the files on dev, but I can revert that change. You can just push it directly to dev if you are happy with it. But I'm also fine with merging a RP :-)

Joe91 commented 1 year ago

Just one proposal: when working on a feature / modification: I think it's best to create a separated Branch for that and try to keep the dev-branch as functional if possible. We can merge back whenever we want but the should also make merging easier when we both develop new features. Of course if it's only a small change just do it directly. And if you prefer to work directly on dev I'm also fine with that 🙂

joao-vitor-souza commented 1 year ago

No problem. I test every unit before I commit something directly to dev, but a branch dedicated to that is actually the best choice, it maintains the commit history more concise.

Joe91 commented 1 year ago

🙂👍

Joe91 commented 1 year ago

Just fixed a little issue with the windows-paths on the root - module so the fun-bots-helper runs again on windows. Hope you are fine with this "workaround". Really looks much cleaner and nicer this way.