Closed jenskm closed 3 years ago
bes-internal
commented
3 years ago Please return default to json_output=false. Behavior completely breaks all logic. In --help I see a -j key that needs to be specified in order to get output in this format, it does not make sense if json on by default, and the key to disable it does not exist at all
JoeDog
commented
3 years ago I changed the default json to false.
I manually edited your change since it was simple. I gave you credit in the ChangeLog. You can cancel the pull request.
Jeff
On Fri, Apr 9, 2021 at 5:11 PM Vladimir Varlamov @.***> wrote:
Please return default to json_output=false. Behavior completely breaks all logic. In --help I see a -j key that needs to be specified in order to get output in this format, it does not make sense if json on by default, and the key to disable it does not exist at all
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JoeDog/siege/issues/185#issuecomment-816973807, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJRHZQC233DYPEVCQM3X4TTH5UORANCNFSM4X4BODSQ .
-- Jeff Fulmer 1-717-799-8226 https://www.joedog.org/ He codes
https://github.com/JoeDog/siege/blob/c91277ff90fc2b4b1835aa7c7ddf4c2385c2f5bc/doc/siegerc.in#L70 Here "json_output" is set to true, but the comment above it says "The default value is false."
Is the default value of "json_output" wrong, or is the documentation wrong?
I think it should default to 'true'. I've just spent a couple of hours trying to figure out why I could not get verbose output before I read in the config file that "json_output" supersedes verbose and debug modes.