rename itoa to fix build on x86_64-pc-msys

[fcharlie]

I use grep find 'itoa' where is used

./include/joedog/joedog.h:66:void  itoa(int, char []);
./lib/joedog/util.c:76:itoa( int n, char s[] )
./lib/joedog/util.h:66:void   itoa(int, char []);

But , When I build siege on MSYS2 , it's failed, when I comment out those, After build and run success,so I rename itoa ,test it on Windows and linux success.

[JoeDog]

Charlie,

I'd like to understand how itoa (a non-standard function) is being referenced on your system. I'd rather just detect it at configure time then wrap my itoa in a macro.

Jeff

On Thu, Sep 17, 2015 at 12:04 AM, Force.Charlie-I notifications@github.com wrote:

I use grep find 'itoa' where is used

./include/joedog/joedog.h:66:void itoa(int, char []); ./lib/joedog/util.c:76:itoa( int n, char s[] ) ./lib/joedog/util.h:66:void itoa(int, char []);

But , When I build siege on MSYS2 http://msys2.github.io/ , it's failed, when I comment out those, After build and run success,so I rename

itoa ,test it on Windows and linux success.

You can view, comment on, or merge this pull request online at:

https://github.com/JoeDog/siege/pull/31 Commit Summary

• rename itoa

File Changes

• M include/joedog/joedog.h https://github.com/JoeDog/siege/pull/31/files#diff-0 (2)
• M lib/joedog/util.c https://github.com/JoeDog/siege/pull/31/files#diff-1 (2)
• M lib/joedog/util.h https://github.com/JoeDog/siege/pull/31/files#diff-2 (2)

Patch Links:

• https://github.com/JoeDog/siege/pull/31.patch
• https://github.com/JoeDog/siege/pull/31.diff

— Reply to this email directly or view it on GitHub https://github.com/JoeDog/siege/pull/31.

[fcharlie]

Hi Jeff itoa in stdio.h

char *  itoa ( int value, char * str, int base );

but in siege

void  itoa(int, char []);

If C++ is not a problem, but c would appear to redefine This is a simple question, you can rename or delete this function, after all, is not found in other places using itoa

Thanks Charlie

[JoeDog]

Yeah, I can just delete it.

On Thu, Sep 17, 2015 at 10:03 AM, Force.Charlie-I notifications@github.com wrote:

Hi Jeff itoa in stdio.h

char * itoa ( int value, char * str, int base );

but in siege

void itoa(int, char []);

If C++ is not a problem, but c would appear to redefine This is a simple question, you can rename or delete this function, after all, is not found in other places using itoa

Thanks Charlie

— Reply to this email directly or view it on GitHub https://github.com/JoeDog/siege/pull/31#issuecomment-141096428.

[fcharlie]

Build it success , Thanks.

$ tree
.
├── bin
│   ├── bombardment.exe
│   ├── siege.config.exe
│   ├── siege.exe
│   └── siege2csv.pl.exe
├── etc
│   ├── siegerc
│   └── urls.txt
└── share
    └── man
        ├── man1
        │   ├── bombardment.1
        │   ├── siege.1
        │   ├── siege.config.1
        │   └── siege2csv.1
        ├── man5
        │   └── urls_txt.5
        └── man7
            └── layingsiege.7

7 directories, 12 files