JoeDog / siege

Siege is an http load tester and benchmarking utility
GNU General Public License v3.0
5.92k stars 386 forks source link

Improve precision in the output timings #89

Closed KayEss closed 1 year ago

KayEss commented 7 years ago

This fixes up some missing gitignore rules and shows transactions times in milliseconds rather than seconds:

** SIEGE 4.0.3rc3
** Preparing 1 concurrent users for battle.
The server is now under siege...
Lifting the server siege...
Transactions:                2180    hits
Availability:                 100.00 %
Elapsed time:                   9.70 secs
Data transferred:               0.88 MB
Response time:                  4.36 ms
Transaction rate:             224.74 trans/sec
Throughput:                     0.09 MB/sec
Concurrency:                    0.98
Successful transactions:     2180
Failed transactions:            0
Longest transaction:           20.00 ms
Shortest transaction:           0.00 ms
xvf commented 7 years ago

Thanks @KayEss. Would be super helpful if this can be made into a config.

KayEss commented 7 years ago

Why would you configure this? If you feel the ms figures are inconvenient for longer transactions then it probably ought to choose the units to display based on the times. I can't see the benefit for the user in having to configure it. Am I missing something?

xvf commented 7 years ago

My thought was it would require additional logic for having the app to figure out the resolution the user requires for the time. Having it configurable will let the user decide it and flip a switch. In my personal experience, when I wanted to change the units, I went through the config file, followed by the github issues and ended up making your change locally.

KayEss commented 7 years ago

I think the only two questions are:

  1. What should the cutoff time be -- I expect anything 10s or more should be in seconds, below that milliseconds is fine.
  2. Should all of the request times have the same units or not? I think it'd be easier to read if they did, so the determination would be taken on the longest time -- should be longest transaction.

The zero reported for shortest transaction most likely points to a timing bug of some sort, but I've not looked into it.

@JoeDog Any thoughts?

hyuansc commented 5 years ago

no merging this request?

JoeDog commented 5 years ago

I plan to merge it. I might make milliseconds an option, not the default.

On Wed, Nov 28, 2018 at 7:27 PM Hao Yuan notifications@github.com wrote:

no merging this request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoeDog/siege/pull/89#issuecomment-442658472, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMT5oXL4UclvMXLjxEdiAuDixNnpdCRks5uzynWgaJpZM4LGZTb .

rimal commented 4 years ago

I plan to merge it. I might make milliseconds an option, not the default. On Wed, Nov 28, 2018 at 7:27 PM Hao Yuan @.***> wrote: no merging this request? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#89 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMT5oXL4UclvMXLjxEdiAuDixNnpdCRks5uzynWgaJpZM4LGZTb .

Has this option been added?

YanBC commented 1 year ago

Guys, how is it going with this feature?

JoeDog commented 1 year ago

This was accepted and merged this morning.

On Sun, Feb 19, 2023 at 11:27 PM yanbc @.***> wrote:

Guys, how is it going with this feature?

— Reply to this email directly, view it on GitHub https://github.com/JoeDog/siege/pull/89#issuecomment-1436314580, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJRHZVGOVUOAKFR7T4GFKDWYLXDTANCNFSM4CYZSTNQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Jeff Fulmer 1-717-799-8226 https://www.joedog.org/ He codes