Closed KayEss closed 1 year ago
Thanks @KayEss. Would be super helpful if this can be made into a config.
Why would you configure this? If you feel the ms figures are inconvenient for longer transactions then it probably ought to choose the units to display based on the times. I can't see the benefit for the user in having to configure it. Am I missing something?
My thought was it would require additional logic for having the app to figure out the resolution the user requires for the time. Having it configurable will let the user decide it and flip a switch. In my personal experience, when I wanted to change the units, I went through the config file, followed by the github issues and ended up making your change locally.
I think the only two questions are:
The zero reported for shortest transaction most likely points to a timing bug of some sort, but I've not looked into it.
@JoeDog Any thoughts?
no merging this request?
I plan to merge it. I might make milliseconds an option, not the default.
On Wed, Nov 28, 2018 at 7:27 PM Hao Yuan notifications@github.com wrote:
no merging this request?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoeDog/siege/pull/89#issuecomment-442658472, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMT5oXL4UclvMXLjxEdiAuDixNnpdCRks5uzynWgaJpZM4LGZTb .
I plan to merge it. I might make milliseconds an option, not the default. … On Wed, Nov 28, 2018 at 7:27 PM Hao Yuan @.***> wrote: no merging this request? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#89 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMT5oXL4UclvMXLjxEdiAuDixNnpdCRks5uzynWgaJpZM4LGZTb .
Has this option been added?
Guys, how is it going with this feature?
This was accepted and merged this morning.
On Sun, Feb 19, 2023 at 11:27 PM yanbc @.***> wrote:
Guys, how is it going with this feature?
— Reply to this email directly, view it on GitHub https://github.com/JoeDog/siege/pull/89#issuecomment-1436314580, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJRHZVGOVUOAKFR7T4GFKDWYLXDTANCNFSM4CYZSTNQ . You are receiving this because you were mentioned.Message ID: @.***>
-- Jeff Fulmer 1-717-799-8226 https://www.joedog.org/ He codes
This fixes up some missing gitignore rules and shows transactions times in milliseconds rather than seconds: