search

JoeFoxe / Hexerei-1.19

0.2.1 update (the book)
12 stars 21 forks source link

[1.20.1 Forge] World deadlock when generating witch huts sometimes #89

Open TelepathicGrunt opened 3 months ago

TelepathicGrunt commented 3 months ago

In the seed 5628964988705595107 at 3870, 140, -390, I did /locate structure hexerei:witch_hut and the game got stuck permanently where chunks stopped loading, mobs stop moving, etc. The main thread is deadlocked and stuck. I did a thread dump and I see the leg processor for the structure is not worldgen safe and managed to lock up the game

image

TelepathicGrunt commented 3 months ago

I think you need to add this safety check to the processor: https://github.com/TelepathicGrunt/RepurposedStructures/blob/fb552179a0976c537c15ed0f4afd2216703bbebc/common/src/main/java/com/telepathicgrunt/repurposedstructures/world/processors/PillarProcessor.java#L82-L84

JoeFoxe commented 3 months ago

Okay I appreciate it :) I should get this update out today for you then- just to double check. would this be correct? because in testing I could never get it to crash image

TelepathicGrunt commented 3 months ago

It should be before the getChunk call.

The issue technically isn’t a crash but the game locking up and ticks stop ticking and chunks stop loading since main thread is waiting on a chunk that is waiting on itself to load while it was loading

JoeFoxe commented 3 months ago

Okay awesome - would you like me to dm you a jar with this fix to be sure this fixes it, or should I just send it and upload to curse