Change default config filename

JoeGandy / ShareX-Custom-Upload

A little PHP script created for uploading custom sharex files to your own webserver

MIT License

165 stars 50 forks source link

Change default config filename #122

Closed davwheat closed 3 years ago

davwheat commented 3 years ago

Closes #120

I've renamed the default config.php to config.default.php. This allows us to easily configure our development setups without risking an accidental push of our config.

Summary

config.php is now ignored in the .gitignore, preventing any accidental pushes.
the default config is now config.default.php
info about copying the default config is now in the README
if someone forgets to copy the default config, we warn them (see below)

More info takes the user to the README on GitHub

theaquarium commented 3 years ago

Yeah, this looks pretty good to me. If you're changing some stuff in README, would you mind changing the Updating section to reflect that the automatic updater now is fully automatic and doesn't require downloading anything.

davwheat commented 3 years ago

@theaquarium Done!

Do we still need default_naming_scheme, use_default_naming_scheme_for_sharex, and use_default_naming_scheme_for_gallery?

The default config doesn't have these in them, but I still get warned about not having them on the gallery page.

The config inside mege_config.php has these, but then doesn't have sharex_upload_naming_scheme, text_upload_default_naming_scheme, etc.

Which ones do we keep, and which do we remove?

theaquarium commented 3 years ago

Great catch, I'm not sure how that happened. The default naming scheme things are from the old config method and I must have somehow forgotten to remove them from the merge config. This is a bit beyond the scope of this PR, so I'll open up a new one to fix it.