search

JoeGandy / ShareX-Custom-Upload

A little PHP script created for uploading custom sharex files to your own webserver
MIT License
166 stars 50 forks source link

Minor fixes and adjustments #67

Closed Jespertastesen closed 4 years ago

Jespertastesen commented 4 years ago

file size now shows MB/GB instead of bytes Added bootstrap theme fixing allowed_ip implode/explode fixing correct value of boolean added allowed_ip as a "tag" in UI

V4B2cJfgeM

Jespertastesen commented 4 years ago

Annotation 2019-11-26 154440 Annotation 2019-11-26 154534

JoeGandy commented 4 years ago

Is it possible to add to be able to have multiple accounts and all those accounts will have their own files. Like being able to have a personal account with your own files nobody can see unless they logged into your account.

Possible yes, but I'd say we keep this out of this project, this is something that could be managed by the server, have a seperat config array for each person then handle that. Not something that would be part of the project. I have no plans to go down the rabbit hole of user auth

Jespertastesen commented 4 years ago

Is it possible to add to be able to have multiple accounts and all those accounts will have their own files. Like being able to have a personal account with your own files nobody can see unless they logged into your account.

Possible yes, but I'd say we keep this out of this project, this is something that could be managed by the server, have a seperat config array for each person then handle that. Not something that would be part of the project. I have no plans to go down the rabbit hole of user auth

Having a simple password protected site like this PR has, is easy enough, but making a multiuser auth, and possible different permissions would be imo too far for a simple file viewer like this.

There is some other out there that has that feature, but i wouldnt open my files up to some one else. If i do, i would trust then enough to give them the master password anyway.

Jespertastesen commented 4 years ago

Is it possible to add to be able to have multiple accounts and all those accounts will have their own files. Like being able to have a personal account with your own files nobody can see unless they logged into your account.

Possible yes, but I'd say we keep this out of this project, this is something that could be managed by the server, have a seperat config array for each person then handle that. Not something that would be part of the project. I have no plans to go down the rabbit hole of user auth

Having a simple password protected site like this PR has, is easy enough, but making a multiuser auth, and possible different permissions would be imo too far for a simple file viewer like this. There is some other out there that has that feature, but i wouldnt open my files up to some one else. If i do, i would trust then enough to give them the master password anyway.

Link?

@Sossa07 Check my latest 2 stars.

the 2. can be combined with this repo. that one is databaseless.

JoeGandy commented 4 years ago

I think looking back at this PR, it does change everything too much, so I'm going to close it for now. I don't want to over complicate what should be a really simple project.

I would say if you're still keen to push this stuff, we can break it down and look at each feature, its just this PR has grown out of the initial scope.