JoeGandy / ShareX-Custom-Upload

A little PHP script created for uploading custom sharex files to your own webserver
MIT License
166 stars 50 forks source link

Added many features and fixed bugs #82

Closed theaquarium closed 4 years ago

theaquarium commented 4 years ago

Hi, thanks for making this. I've wanted to set up an image uploader for a while. There were a bunch of features that I also wanted to have, so I added them:

I've ended up restructuring a lot of the project and I've moved all the code out of the u/ folder so there are a lot of breaking changes. My fork is also significantly more bulky, so if you'd prefer, I can just continue my fork separately.

Let me know what you think.

JoeGandy commented 4 years ago

Really nice! It's definitely worth getting this merged in, i'll find some time to run some tests locally and write a bit of a migration how to for the breaking changes.

But really happy to have some one improving the project!

theaquarium commented 4 years ago

Thanks! If you'd like I can start managing releases and we can release this as v2. I think all users should need to do to upgrade is run something like find . -maxdepth 1 -not -name "*.php" -exec cp '{}' ../backupfiles/ ';' to copy their uploaded images into a separate folder, reinstall the new version of the uploader, and copy the files back. I've started writing up a quick guide on how to do this.

theaquarium commented 4 years ago

On an unrelated note, could you consider releasing this project under an open source license (like MIT)?

JoeGandy commented 4 years ago

Thanks! If you'd like I can start managing releases and we can release this as v2. I think all users should need to do to upgrade is run something like find . -maxdepth 1 -not -name "*.php" -exec cp '{}' ../backupfiles/ ';' to copy their uploaded images into a separate folder, reinstall the new version of the uploader, and copy the files back. I've started writing up a quick guide on how to do this.

Sounds good to me, might be worth popping a quick migrating from v1->v2 on this PR in plain text for none techy people would be nice, (essentially just move all files that arent php into /backupfiles/)

On an unrelated note, could you consider releasing this project under an open source license (like MIT)?

Absolutely, I'll drop in the MIT license

theaquarium commented 4 years ago

Thanks for the comments! Are we ready to merge?

JoeGandy commented 4 years ago

Nice one, and feel free to take some control in terms of releases